Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Maven wrapper for Jib example easier start. #1471

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Use Maven wrapper for Jib example easier start. #1471

merged 3 commits into from
Jan 16, 2019

Conversation

ivanporty
Copy link
Contributor

When working on coming IntelliJ IDE plugin demos, running Jib example is not as easy as it could be with a added Maven wrapper. Maven is required in PATH for example to work, but it may not be used at all (i.e. developer uses Gradle instead) or not used in CLI (internal IDE support for Maven). Maven wrapper will download and provide Maven automatically and Jib knows how to pick it up.

Also, this PR exposes container port for port forwarding in the container section, without it skaffold does not port-forward 8080 automatically.

@codecov-io
Copy link

Codecov Report

Merging #1471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   44.43%   44.43%           
=======================================
  Files         112      112           
  Lines        4641     4641           
=======================================
  Hits         2062     2062           
  Misses       2372     2372           
  Partials      207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f99903...da6f979. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #1471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   44.43%   44.43%           
=======================================
  Files         112      112           
  Lines        4641     4641           
=======================================
  Hits         2062     2062           
  Misses       2372     2372           
  Partials      207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f99903...5e280ca. Read the comment docs.

Copy link
Contributor

@coollog coollog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use version 3.6.0 since that is the latest?

@ivanporty
Copy link
Contributor Author

Sure, good idea, I'll bump up the version.

@dgageot
Copy link
Contributor

dgageot commented Jan 15, 2019

@ivanporty this is awesome. One issue, you have to also fix the same sample under integration/examples. I know this is painful...

@ivanporty
Copy link
Contributor Author

Ah, good to know, let me make the changes there as well.

@ivanporty
Copy link
Contributor Author

@dgageot the integration example is updated as well, let me know if something else is missing, thanks!

@dgageot dgageot merged commit 8fdb68b into GoogleContainerTools:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants