Show duplication in jib code #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @GoogleContainerTools/java-tools |
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
+ Coverage 44.33% 44.41% +0.08%
==========================================
Files 113 113
Lines 4660 4667 +7
==========================================
+ Hits 2066 2073 +7
Misses 2386 2386
Partials 208 208
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
jib-show-duplication
branch
from
e3387c5 to
407ca04
Compare
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
jib-show-duplication
branch
from
407ca04 to
add22d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some duplication in jib code with regards to maven/gradle args.
This PR moves similar code fragments next to one another to make them easier to maintain.
Ideally, this duplication can be removed but I don't know enough jib to ensure I'm not breaking something.