Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear error message for unsupported artifact on GCB #1453

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 11, 2019

Also prepare the support for other artifacts types

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #1453 into master will increase coverage by 0.14%.
The diff coverage is 85.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
+ Coverage   44.19%   44.33%   +0.14%     
==========================================
  Files         112      113       +1     
  Lines        4641     4660      +19     
==========================================
+ Hits         2051     2066      +15     
- Misses       2382     2386       +4     
  Partials      208      208
Impacted Files Coverage Δ
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/gcb/docker.go 100% <100%> (ø)
pkg/skaffold/build/gcb/desc.go 93.75% <88.23%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3232a19...30b9e6f. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did you mean to check in the debug.test file?

@dgageot
Copy link
Contributor Author

dgageot commented Jan 11, 2019

No, indeed. I’ll remove it. Thanks!

Also prepare the support for other artifacts types

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 967c35d into GoogleContainerTools:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants