Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc around local development #1446

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

shavo007
Copy link
Contributor

Related to this issue #1392

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #1446 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
- Coverage   44.53%   44.25%   -0.28%     
==========================================
  Files         112      112              
  Lines        4596     4634      +38     
==========================================
+ Hits         2047     2051       +4     
- Misses       2342     2375      +33     
- Partials      207      208       +1
Impacted Files Coverage Δ
pkg/skaffold/watch/triggers.go 21.12% <0%> (-12.21%) ⬇️
pkg/skaffold/watch/watch.go 82.6% <0%> (-3.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3795677...6371a85. Read the comment docs.

@shavo007
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@priyawadhwa priyawadhwa added kokoro:run runs the kokoro jobs on a PR docs-modifications runs the docs preview service on the given PR labels Jan 10, 2019
@container-tools-bot
Copy link

Please visit http://35.236.19.246:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 10, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, just had one comment!

docs/content/en/docs/getting-started/_index.md Outdated Show resolved Hide resolved
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 10, 2019
@priyawadhwa priyawadhwa added the docs-modifications runs the docs preview service on the given PR label Jan 10, 2019
@container-tools-bot
Copy link

Please visit http://35.235.81.81:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 10, 2019
@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Jan 11, 2019
@shavo007
Copy link
Contributor Author

👀 on above?

@priyawadhwa priyawadhwa added kokoro:run runs the kokoro jobs on a PR and removed kokoro:run runs the kokoro jobs on a PR labels Jan 22, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 22, 2019
@priyawadhwa
Copy link
Contributor

Thanks for your contribution!

@priyawadhwa priyawadhwa merged commit ac65cd3 into GoogleContainerTools:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants