Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trigger related code to the watcher #1422

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 24, 2018

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1422 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   44.77%   44.79%   +0.01%     
==========================================
  Files         111      111              
  Lines        4554     4552       -2     
==========================================
  Hits         2039     2039              
+ Misses       2310     2308       -2     
  Partials      205      205
Impacted Files Coverage Δ
pkg/skaffold/watch/watch.go 86.04% <100%> (+1.04%) ⬆️
pkg/skaffold/runner/runner.go 61.22% <100%> (-0.27%) ⬇️
pkg/skaffold/runner/dev.go 50% <100%> (-2.78%) ⬇️
pkg/skaffold/watch/triggers.go 33.33% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268f4dc...fb088e6. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1422 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   44.77%   44.79%   +0.01%     
==========================================
  Files         111      111              
  Lines        4554     4552       -2     
==========================================
  Hits         2039     2039              
+ Misses       2310     2308       -2     
  Partials      205      205
Impacted Files Coverage Δ
pkg/skaffold/watch/watch.go 86.04% <100%> (+1.04%) ⬆️
pkg/skaffold/runner/runner.go 61.22% <100%> (-0.27%) ⬇️
pkg/skaffold/runner/dev.go 50% <100%> (-2.78%) ⬇️
pkg/skaffold/watch/triggers.go 33.33% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268f4dc...fb088e6. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit 48ca967 into GoogleContainerTools:master Dec 27, 2018
@dgageot dgageot deleted the simplify-trigger branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants