Apply default values upgraded configurations

[dgageot]

Default values need to be set after upgrade, not before. In fact, default values are only needed to simplify the code of the runner, so that it doesn't have to compensate missing fields.

I used this opportunity to:

• improve the code and coverage for skaffold fix
• Remove duplication in code and tests

Signed-off-by: David Gageot david@gageot.net

[balopat]

Thank you! can you implement the tests for it as well? We have a reasonable coverage now, shouldn't be hard.

[codecov-io]

Codecov Report

Merging #1332 into master will decrease coverage by 0.12%.
The diff coverage is 46.87%.

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   44.84%   44.71%   -0.13%     
==========================================
  Files         110      114       +4     
  Lines        4797     4880      +83     
==========================================
+ Hits         2151     2182      +31     
- Misses       2425     2476      +51     
- Partials      221      222       +1

Impacted Files	Coverage Δ
pkg/skaffold/schema/v1alpha5/config.go	50% <ø> (+4.54%)	⬆️
pkg/skaffold/schema/v1alpha3/config.go	50% <ø> (+4.54%)	⬆️
pkg/skaffold/schema/v1alpha4/config.go	50% <ø> (+4.54%)	⬆️
pkg/skaffold/schema/v1alpha1/config.go	50% <ø> (-7.15%)	⬇️
pkg/skaffold/schema/v1alpha2/config.go	50% <ø> (+4.54%)	⬆️
cmd/skaffold/app/cmd/dev.go	0% <0%> (ø)	⬆️
pkg/skaffold/schema/v1alpha1/defaults.go	0% <0%> (ø)
cmd/skaffold/app/cmd/run.go	0% <0%> (ø)	⬆️
cmd/skaffold/app/cmd/diagnose.go	0% <0%> (ø)	⬆️
cmd/skaffold/app/cmd/init.go	15.42% <0%> (ø)	⬆️
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a4adf...3335346. Read the comment docs.