Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node security issue #1323

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 27, 2018

Also fix the missing Dockerfile and package.json
in hot-reload sample

Signed-off-by: David Gageot david@gageot.net

Also fix the missing Dockerfile and package.json
in hot-reload sample

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #1323 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1323   +/-   ##
=======================================
  Coverage   45.04%   45.04%           
=======================================
  Files         107      107           
  Lines        4740     4740           
=======================================
  Hits         2135     2135           
  Misses       2384     2384           
  Partials      221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9536a6c...cd1c598. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 9c2e4bb into GoogleContainerTools:master Nov 27, 2018
@dgageot dgageot deleted the fix-node-security-issue branch December 28, 2018 07:13
kelsk pushed a commit to kelsk/skaffold that referenced this pull request Apr 16, 2021
Also fix the missing Dockerfile and package.json
in hot-reload sample

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants