Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arguments to bazel build #1289

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

jamielennox
Copy link

To make a container capable of being used by skaffold I need to be able
to provide additional parameters on the command line. Add an args:
element to the bazel build configuration that is a list of strings that
will be passed to the build command.

To make a container capable of being used by skaffold I need to be able
to provide additional parameters on the command line. Add an args:
element to the bazel build configuration that is a list of strings that
will be passed to the build command.
@jamielennox
Copy link
Author

My specific requirement here is that I'm running bazel on OSX with a golang codebase. There are a couple of problems to do with the toolchain, gazelle, that don't resolve dependencies correctly when simply specify cross compile parameters. The advice from bazel is to pass "--platforms=@io_bazel_rules_go//go/toolchain:linux_amd64" to the build process.

This will provide a way to set these parameters.

@codecov-io
Copy link

Codecov Report

Merging #1289 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   44.24%   44.21%   -0.03%     
==========================================
  Files         104      104              
  Lines        4629     4632       +3     
==========================================
  Hits         2048     2048              
- Misses       2372     2375       +3     
  Partials      209      209
Impacted Files Coverage Δ
pkg/skaffold/build/local/bazel.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d808c...535a0ab. Read the comment docs.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Nov 20, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 20, 2018
@balopat balopat merged commit 134337b into GoogleContainerTools:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants