Support slashes in file sync glob patterns on windows #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
priyawadhwa
force-pushed
the
windows-sync
branch
from
096d43c to
e8d3d39
Compare
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
- Coverage 44.3% 44.24% -0.06%
==========================================
Files 104 104
Lines 4623 4629 +6
==========================================
Hits 2048 2048
- Misses 2366 2372 +6
Partials 209 209
Continue to review full report at Codecov.
|
priyawadhwa
force-pushed
the
windows-sync
branch
from
e8d3d39 to
5ab1f98
Compare
nkubala
approved these changes
Nov 16, 2018
balopat
suggested changes
Nov 16, 2018
There was a problem hiding this comment.
Actually this became a legit PR as it failed without the FromSlashes: https://ci.appveyor.com/project/r2d4/skaffold/builds/20334943
Please rename it to "support slashes in sync glob patterns on windows" + the little nits and we're good to go! Thank you!
pkg/skaffold/sync/sync_test.go
Outdated
| @@ -210,6 +210,32 @@ func TestNewSyncItem(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| description: "test filepaths", | |||
There was a problem hiding this comment.
Suggested change
| description: "test filepaths", | |
| description: "slashes in glob pattern", |
pkg/skaffold/sync/sync_test.go
Outdated
| }, | ||
| }, | ||
| evt: watch.Events{ | ||
| Added: []string{filepath.Join("node", "node/node.js")}, |
There was a problem hiding this comment.
Suggested change
| Added: []string{filepath.Join("node", "node/node.js")}, | |
| Added: []string{filepath.Join("folder1", "folder2/node.js")}, |
just to make it a bit more understandable. too many nodes :)
balopat
changed the title
balopat
changed the title
balopat
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1266 failed on appveyor because the new library couldn't process windows paths.
filepath.Match also doesn't handle paths for windows itself, so I applied filepath.FromSlash() to each pattern before matching.