Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Kind on skaffold init #1237

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 6, 2018

Fixes #1236

@codecov-io
Copy link

Codecov Report

Merging #1237 into master will increase coverage by 0.72%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
+ Coverage   41.45%   42.17%   +0.72%     
==========================================
  Files          96       96              
  Lines        4238     4239       +1     
==========================================
+ Hits         1757     1788      +31     
+ Misses       2310     2277      -33     
- Partials      171      174       +3
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/init.go 15.89% <100%> (+15.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23693e8...4d2bd25. Read the comment docs.

@r2d4 r2d4 merged commit 72d69cf into GoogleContainerTools:master Nov 6, 2018
@dgageot dgageot deleted the fix-1236 branch December 28, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants