Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating a service from webhook #1213

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

priyawadhwa
Copy link
Contributor

Added code for creating a service for a pull request and getting the
external IP associated with that service. The next PR will add support
for creating a deployment which will interact with the service.

Added code for creating a service for a pull request and getting the
external IP associated with that service. The next PR will add support
for creating a deployment which will interact with the service.
@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #1213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   41.41%   41.41%           
=======================================
  Files          95       95           
  Lines        4233     4233           
=======================================
  Hits         1753     1753           
  Misses       2309     2309           
  Partials      171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1731195...fe07604. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@priyawadhwa priyawadhwa merged commit 71131fe into GoogleContainerTools:master Oct 30, 2018
@priyawadhwa priyawadhwa deleted the webhook branch October 30, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants