Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare next version of the config file #1146

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 12, 2018

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #1146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   41.45%   41.45%           
=======================================
  Files          95       95           
  Lines        4229     4229           
=======================================
  Hits         1753     1753           
  Misses       2305     2305           
  Partials      171      171
Impacted Files Coverage Δ
pkg/skaffold/schema/v1alpha3/upgrade.go 69.69% <ø> (ø) ⬆️
pkg/skaffold/schema/versions.go 56.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c27520...7bf26b7. Read the comment docs.

@dgageot dgageot force-pushed the v1alpha5 branch 3 times, most recently from 26f9799 to 06c01bc Compare October 22, 2018 08:48
@balopat balopat mentioned this pull request Oct 23, 2018
Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat
Copy link
Contributor

balopat commented Oct 26, 2018

Thank you very much for preparing this!

@balopat balopat merged commit bef7858 into GoogleContainerTools:master Oct 26, 2018
balopat added a commit to balopat/skaffold that referenced this pull request Oct 26, 2018
Prepare next version of the config file
@dgageot dgageot deleted the v1alpha5 branch December 28, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants