Minor logging improvements #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
=========================================
- Coverage 42.31% 42.2% -0.11%
=========================================
Files 89 89
Lines 3982 3992 +10
=========================================
Hits 1685 1685
- Misses 2129 2139 +10
Partials 168 168
Continue to review full report at Codecov.
|
dgageot
previously requested changes
Oct 11, 2018
pkg/skaffold/bazel/bazel.go
Outdated
| @@ -65,6 +66,8 @@ func GetDependencies(ctx context.Context, workspace string, a *latest.BazelArtif | |||
| deps = append(deps, "WORKSPACE") | |||
| } | |||
|
|
|||
| logrus.Debugf("Found dependencies for bazel artifact: %s", deps) | |||
There was a problem hiding this comment.
Should you use %v not a slice?
There was a problem hiding this comment.
it actually prints the exact same thing either way, but you're right %v is more correct. fixed
priyawadhwa
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log (INFO) which files were added/modified/deleted when a rebuild is triggered. Change the dockerfile dependencies log level to DEBUG (since it happens every second), and add debug logs for other artifact types.