Fix kaniko default behaviour #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
If buildcontext isn't specified or localdir is specified, return localdir as the source context. Otherwise, return a GCS bucket. If no value is passed in for the bucket, one will be inferred from the project ID.
priyawadhwa
force-pushed
the
kanikobug
branch
from
890d343 to
5f4df39
Compare
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 42.23% 42.31% +0.08%
==========================================
Files 90 89 -1
Lines 3990 3982 -8
==========================================
Hits 1685 1685
+ Misses 2137 2129 -8
Partials 168 168
Continue to review full report at Codecov.
|
dgageot
suggested changes
Oct 11, 2018
| @@ -35,7 +35,7 @@ type BuildContextSource interface { | |||
|
|
|||
| // Retrieve returns the correct build context based on the config | |||
| func Retrieve(cfg *latest.KanikoBuild) (BuildContextSource, error) { | |||
| if cfg.BuildContext.LocalDir != nil { | |||
| if cfg.BuildContext == nil || cfg.BuildContext.LocalDir != nil { | |||
There was a problem hiding this comment.
Setting default config should be done in
so thatBuildContext is never nil
when parsing the config so that buildcontext is never nil
dgageot
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If buildcontext isn't specified or localdir is specified, return localdir as the source
context. Otherwise, return a GCS bucket. If no value is passed in for
the bucket, one will be inferred from the project ID.