skipPush -> push #1114
Merged
skipPush -> push #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 42.96% 43.14% +0.18%
==========================================
Files 74 77 +3
Lines 3403 3537 +134
==========================================
+ Hits 1462 1526 +64
- Misses 1801 1858 +57
- Partials 140 153 +13
Continue to review full report at Codecov.
|
|
Thanks for catching that @dgageot! Done. |
dgageot
suggested changes
Oct 8, 2018
skaffold.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: skaffold/v1alpha3 | |||
| kind: Config | |||
| build: | |||
| artifacts: | |||
| - image: gcr.io/k8s-skaffold/skaffold | |||
| - imageName: gcr.io/k8s-skaffold/skaffold | |||
| docker: | |||
| dockerfile: deploy/skaffold/Dockerfile | |||
There was a problem hiding this comment.
I think dockerfile should be dockerfilePath
There was a problem hiding this comment.
agreed - I changed it
nkubala
approved these changes
Oct 8, 2018
dgageot
approved these changes
Oct 9, 2018
| @@ -77,7 +77,8 @@ build: | |||
| # `useBuildkit` can also be set to activate the experimental BuildKit feature. | |||
| # | |||
| # local: | |||
| # skipPush: true | |||
| # false by default for local clusters, true for remote clusters | |||
| # push: false | |||
There was a problem hiding this comment.
The doc in the previous paragraph still talks about skip push, with inverted boolean value: this is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113.