Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of improvements to the test phase #1080

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 3, 2018

No description provided.

Also fix a few comments

Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#1079

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Oct 3, 2018

Codecov Report

Merging #1080 into master will increase coverage by 0.01%.
The diff coverage is 8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   42.57%   42.58%   +0.01%     
==========================================
  Files          71       71              
  Lines        3239     3238       -1     
==========================================
  Hits         1379     1379              
+ Misses       1727     1726       -1     
  Partials      133      133
Impacted Files Coverage Δ
pkg/skaffold/runner/timings.go 15% <0%> (+0.36%) ⬆️
pkg/skaffold/runner/runner.go 53.21% <40%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95df153...f2465c5. Read the comment docs.

@dgageot dgageot changed the title Couple of improvements on the test phase Couple of improvements to the test phase Oct 3, 2018
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit 101f534 into GoogleContainerTools:master Oct 4, 2018
@dgageot dgageot deleted the improve-tests branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants