Transform values files in profiles to v1alpha3

[GeertJohan]

I made a mistake in #985. With the v0.15.0 skaffold fix the valuesFilePath field in profiles is completely dropped. These changes fix that.

These changes are based on the v0.15.0 tag. I think this PR shouldn't actually point to master but to a v0.15.x branch from which we may release v0.15.1

Apologies for the inconvenience. I hope it's possible to push out a hotfix release fast.

[codecov-io]

Codecov Report

Merging #1070 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   40.86%   40.86%           
=======================================
  Files          70       70           
  Lines        3091     3091           
=======================================
  Hits         1263     1263           
  Misses       1703     1703           
  Partials      125      125

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec4835...06b0e15. Read the comment docs.

[balopat]

Thanks for filling this back in :)
Can you please write a test for this?
Thank you!

[GeertJohan]

@balopat Was already looking at that, but tests for the transform seem to be missing completely so it'll take a bit more time.

edit: Actually I'm not sure what would be the best approach to test the transform functions.. I suggest a string comparison; input A, expect B. Would that be sufficient?

[balopat]

Yeah, I think with transformation logic we could go as thorough as covering quick-check style a lot of combinations, or the lazy way is to provide a couple of full golden examples and provide some coverage.

We do have a "the conversion doesn't fail and the result is deployable" test at https://github.com/GoogleContainerTools/skaffold/blob/master/integration/run_test.go#L224 but that should already cover your case.

And with that, I'm going to unblock this PR. I think we should improve the test coverage on these though on the long run or do a better validation integration test.

[GeertJohan]

@balopat Can we release this hotfix as v0.15.1? Otherwise users will break their skaffold.yaml when switching to v0.15.0 and v0.16.0 is still a few weeks away I guess?
cc @r2d4

[balopat]

Yes, I will work on the v0.15.1 release today!