Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Sync for skaffold dev #1039

Merged
merged 24 commits into from
Oct 5, 2018
Merged

File Sync for skaffold dev #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1d2281a
[examples] add webserver file sync example
r2d4 Sep 26, 2018
350f0b0
[kubernetes] add kubectl syncer
r2d4 Sep 26, 2018
9a1d4d0
[runner] add sync step to skaffold dev
r2d4 Sep 26, 2018
64af3ab
[examples] add readme to webserver example
r2d4 Sep 26, 2018
884e6b3
[linter] fixes
r2d4 Sep 26, 2018
16415be
review feedback
r2d4 Sep 26, 2018
98b2219
[vendor] add x/sync/errgroup
r2d4 Sep 26, 2018
f0ed4cd
[linter] add boilerplate to sync_test.go
r2d4 Sep 26, 2018
c511693
File changes should be relative to artifact context
r2d4 Sep 27, 2018
88f3d02
rename webserver example to hot reload
r2d4 Sep 28, 2018
6edae2e
[sync] move to sync package, move logic to watch main loop
r2d4 Sep 28, 2018
81bd94c
[examples] add flask hot-reload example
r2d4 Sep 28, 2018
f7b8a44
add boilerplate
r2d4 Sep 28, 2018
799d630
linter fixes
r2d4 Sep 30, 2018
d565e05
rebase on v1alpha4
r2d4 Sep 30, 2018
931b5d8
fix windows test
r2d4 Sep 30, 2018
35ef51c
[parse] remove loud debug statements
r2d4 Oct 1, 2018
3f8ba1e
[sync] query only skaffold pods, use exact tag
r2d4 Oct 1, 2018
c7b0fd5
rebase on v1alpha4 config
r2d4 Oct 2, 2018
10d5d31
delete out of date readme
r2d4 Oct 3, 2018
8f9ac9a
add legacy watch for nodemon example
r2d4 Oct 3, 2018
8a22fd8
review feedback
r2d4 Oct 4, 2018
be4cc6c
rebase changes
r2d4 Oct 4, 2018
9b11bc4
debug and info messages only for sync
r2d4 Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Gopkg.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion cmd/skaffold/app/cmd/fix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ import (

"github.com/GoogleContainerTools/skaffold/pkg/skaffold/color"
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema"
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/latest"
schemautil "github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/util"

"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
yaml "gopkg.in/yaml.v2"
"k8s.io/client-go/tools/clientcmd/api/latest"
)

func NewCmdFix(out io.Writer) *cobra.Command {
Expand Down
3 changes: 3 additions & 0 deletions integration/examples/hot-reload/node/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
FROM gcr.io/k8s-skaffold/nodemon
CMD ["nodemon","--legacy-watch", "server.js"]
COPY *.js .
10 changes: 10 additions & 0 deletions integration/examples/hot-reload/node/k8s/pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: v1
kind: Pod
metadata:
name: node
spec:
containers:
- name: node
image: gcr.io/k8s-skaffold/node-example
ports:
- containerPort: 3000
Loading