Improve kustomize deployer #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
+ Coverage 40.13% 40.92% +0.78%
==========================================
Files 70 70
Lines 3077 3079 +2
==========================================
+ Hits 1235 1260 +25
+ Misses 1718 1694 -24
- Partials 124 125 +1
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
improve-kustomize
branch
from
8f878fe to
39ac758
Compare
nkubala
approved these changes
Sep 26, 2018
pkg/skaffold/deploy/kustomize.go
Outdated
| ConfigMapGenerator []configMapGenerator `yaml:"configMapGenerator"` | ||
| } | ||
|
|
||
| type patcheJSON6902 struct { |
There was a problem hiding this comment.
patcheJSON6902 -> patchesJSON6902
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1031 Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1033 Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1034 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
improve-kustomize
branch
from
39ac758 to
e78da12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests and fixes #1034, #1033 , #1031