Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git tagger should use tags only in case of perfect match #754

Closed
dgageot opened this issue Jun 27, 2018 · 0 comments
Closed

git tagger should use tags only in case of perfect match #754

dgageot opened this issue Jun 27, 2018 · 0 comments
Assignees
@dgageot
Labels
area/tag kind/bug Something isn't working

Comments

@dgageot
Copy link
Contributor

dgageot commented Jun 27, 2018

Take a git repo that has a v1 tag. Add another commit on top. git tagger will then give a tag that looks like v1-1-gbdd8958. We should rather use the commit sha1.
@dgageot dgageot added kind/bug Something isn't working area/tag labels Jun 27, 2018
@dgageot dgageot self-assigned this Jun 27, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2018
@dgageot
Use tags only in case of perfect match
03b8889 
Fix GoogleContainerTools#754
@dgageot dgageot mentioned this issue Jun 27, 2018
Merged
@r2d4 r2d4 closed this as completed in #755 Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/tag kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgageot