Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange behaviour with .dockerignore #386

Closed
antonversal opened this issue Apr 13, 2018 · 2 comments
Closed

strange behaviour with .dockerignore #386

antonversal opened this issue Apr 13, 2018 · 2 comments
Assignees
Labels
kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@antonversal
Copy link

microservices example

Expected behavior

should ignore files stated in .dockerignore without **, like app.go

Actual behavior

only ignores files which have **, like **/app.go

Information

Given microservices example
And .dockerignore file in same folder as Dockerfile with content app.go
When skaffold dev is run
It does not ignore app.go

Skaffold version: 0.4.0
Operating system: macOS
Content of skaffold.yaml: 
apiVersion: skaffold/v1alpha2
kind: Config
build:
  artifacts:
  - imageName: gcr.io/k8s-skaffold/leeroy-web
    workspace: ./leeroy-web/
    docker: {}
  - imageName: gcr.io/k8s-skaffold/leeroy-app
    workspace: ./leeroy-app/
    docker: {}
  local: {}
deploy:
  kubectl:
    manifests:
    - ./leeroy-web/kubernetes/*
    - ./leeroy-app/kubernetes/*

Steps to reproduce the behavior

  1. echo 'app.go' > leeroy-app/.dockerignore
  2. skaffold dev should fail
@dgageot dgageot added the kind/bug Something isn't working label Apr 13, 2018
@r2d4 r2d4 added the priority/p0 Highest priority. We are actively looking at delivering it. label Apr 23, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 25, 2018
@dgageot dgageot self-assigned this Apr 26, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 27, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 5, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 8, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 8, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 8, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 10, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 11, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 14, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 14, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 14, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 16, 2018
@dgageot
Copy link
Contributor

dgageot commented May 16, 2018

@antonversal this should be fixed in 0.6.0. Can you confirm?

@dgageot
Copy link
Contributor

dgageot commented May 16, 2018

oh no. not merged... Forget about it ;-)

dgageot added a commit to dgageot/skaffold that referenced this issue May 16, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 16, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 17, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue May 17, 2018
Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

No branches or pull requests

3 participants