Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold dev with kustomize doesn't pick up patchesStrategicMerge changes #2344

Closed
reegnz opened this issue Jun 26, 2019 · 1 comment · Fixed by #2349
Closed

skaffold dev with kustomize doesn't pick up patchesStrategicMerge changes #2344

reegnz opened this issue Jun 26, 2019 · 1 comment · Fixed by #2349
Assignees
Labels
deploy/kustomize kind/bug Something isn't working

Comments

@reegnz
Copy link

reegnz commented Jun 26, 2019

Expected behavior

When I use a kustomize v2.x manifest, skaffold dev should pick up changes to any of the changes to files kustomize is working with.

Actual behavior

If I am using patchesStrategicMerge the changes to the patches aren't picked up.
If I use 1.x format (patches) the patch changes are picked up by skaffold dev properly.

Information

  • Skaffold version: v0.32.0
  • Operating system: MacOS Mojave 10.14.5
  • Contents of skaffold.yaml:
apiVersion: skaffold/v1beta11
kind: Config
build:
  artifacts:
  - image: my-image
deploy:
  kustomize:
    path: deployment

Steps to reproduce the behavior

  1. create a basic deployment
  2. add a kustomize.yaml
  3. create a strategic merge patch file to patch the deployment
  4. add the patch with kustomize cli:
kustomize edit add patch thepatch.yaml

This creates a patchesStrategicMerge entry in the kustomization file
5. Run skaffold dev
6. Change the patch
7. Observe that no new deployment is made.

Why this change is important is because patches is deprecated since 2.0 in favour of patchesStrategicMerge.

@dgageot dgageot added deploy/kustomize kind/bug Something isn't working labels Jun 26, 2019
@dgageot dgageot self-assigned this Jun 26, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Fixes GoogleContainerTools#2344

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit that referenced this issue Jun 26, 2019
Fixes #2344

Signed-off-by: David Gageot <david@gageot.net>
@reegnz
Copy link
Author

reegnz commented Jun 27, 2019

Thanks for the insanely fast fix! You're awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy/kustomize kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants