Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiline docker ENV commands correctly #1625

Closed
corneliusweig opened this issue Feb 7, 2019 · 0 comments · Fixed by #1626
Closed

Handle multiline docker ENV commands correctly #1625

corneliusweig opened this issue Feb 7, 2019 · 0 comments · Fixed by #1626

Comments

@corneliusweig
Copy link
Contributor

Expected behavior

Skaffold correctly builds dockerfiles with multiline ENV commands.

Actual behavior

Skaffold fails with

FATA[0000] build failed: building [test-build-with-multiline-env]: build artifact: COPY failed: stat <redacted>/tmp/docker-builder563927127/b/file: no such file or directory

Information

  • Skaffold version: master
  • Operating system: Linux

Steps to reproduce the behavior

  1. preparation:

    # prepare folders environment:
    mkdir b && echo "file in dir b" > b/file
    mkdir a && echo "file in dir a" > a/file
  2. skaffold.yaml:

    apiVersion: skaffold/v1beta4
    kind: Config
    build:
      artifacts:
      - image: test-build-with-multiline-env
  3. Dockerfile:

    FROM busybox
    
    ENV AAA=a \
        BBB=b
    
    COPY ./${BBB}/file /tmp/
    
  4. skaffold build fails, whereas docker build . works fine

corneliusweig pushed a commit to corneliusweig/skaffold that referenced this issue Feb 7, 2019
…erTools#1625)

Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
corneliusweig pushed a commit to corneliusweig/skaffold that referenced this issue Feb 7, 2019
…erTools#1625)

Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
balopat pushed a commit that referenced this issue Feb 8, 2019
Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant