Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parallel local image building. #1380

Closed
tmc opened this issue Dec 10, 2018 · 1 comment · Fixed by #3471
Closed

Add parallel local image building. #1380

tmc opened this issue Dec 10, 2018 · 1 comment · Fixed by #3471
Assignees
@dgageot
Labels
area/build kind/feature-request priority/p2 May take a couple of releases

Comments

@tmc
Copy link
Contributor

tmc commented Dec 10, 2018

#248 added parallel building to gcb+kaniko, but not local builds.

Expected behavior

That local builds use InParallel

Actual behavior

Local builds use InSequence
@dgageot dgageot self-assigned this Jan 20, 2019
@briandealwis briandealwis mentioned this issue Mar 29, 2019
Merged
@dgageot dgageot removed their assignment Apr 8, 2019
@balopat balopat mentioned this issue Aug 22, 2019
Closed
@balopat balopat added the priority/p2 May take a couple of releases label Aug 22, 2019
@balopat
Copy link
Contributor

balopat commented Aug 22, 2019

I would love to have this somehow.

Thoughts:

This is only for local builds.
On cluster and gcb builds we have parallel builds.

  1. We experimented with this before for local builds but things were breaking back then . @dgageot maybe it's worth having another look now
  2. There are people who depend on sequenced builds - they use it as a poor man's dependency management solution.

@tbarrella tbarrella mentioned this issue Aug 30, 2019
Closed
@dgageot dgageot self-assigned this Jan 2, 2020
dgageot added a commit to dgageot/skaffold that referenced this issue Jan 2, 2020
@dgageot
Support // builds with local builder
34b0d31 
Defaults to a sequential build

Fixes GoogleContainerTools#1380

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jan 3, 2020
@dgageot
Support // builds with local builder
b803822 
Defaults to a sequential build

Fixes GoogleContainerTools#1380

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jan 3, 2020
@dgageot
Support // builds with local builder
08d07cf 
Defaults to a sequential build

Fixes GoogleContainerTools#1380

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Jan 7, 2020
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Jan 7, 2020
@dgageot
Support // builds with local builder
fd90ca0 
Defaults to a sequential build

Fixes GoogleContainerTools#1380

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jan 8, 2020
@dgageot
Support // builds with local builder
b8300ce 
Defaults to a sequential build

Fixes GoogleContainerTools#1380

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jan 8, 2020
@dgageot
Support // builds with local builder
c9a0a87 
Defaults to a sequential build

Fixes GoogleContainerTools#1380

Signed-off-by: David Gageot <david@gageot.net>
@matti matti mentioned this issue Jan 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/build kind/feature-request priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support parallel local builds (defaults to sequential) dgageot/skaffold
4 participants
@tmc @dgageot @balopat @priyawadhwa