Better mock for docker.ImageID

Signed-off-by: David Gageot <david@gageot.net>
GoogleContainerTools · Jul 12, 2019 · f432fa8 · f432fa8
1 parent b3e079d
commit f432fa8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/pkg/skaffold/docker/image_test.go b/pkg/skaffold/docker/image_test.go
@@ -218,7 +218,7 @@ func TestImageID(t *testing.T) {
 		{
 			description: "not found",
 			ref:         "somethingelse",
-			shouldErr:   true,
+			expected:    "",
 		},
 	}
 	for _, test := range tests {

diff --git a/testutil/fake_image_api.go b/testutil/fake_image_api.go
@@ -49,6 +49,14 @@ type FakeAPIClient struct {
 	PushedImages []string
 }
 
+type notFoundError struct {
+	error
+}
+
+func (e notFoundError) NotFound() bool {
+	return true
+}
+
 type errReader struct{}
 
 func (f errReader) Read([]byte) (int, error) { return 0, fmt.Errorf("") }
@@ -95,7 +103,7 @@ func (f *FakeAPIClient) ImageInspectWithRaw(_ context.Context, ref string) (type
 
 	id, ok := f.TagToImageID[ref]
 	if !ok {
-		return types.ImageInspect{}, nil, fmt.Errorf("")
+		return types.ImageInspect{}, nil, &notFoundError{}
 	}
 
 	rawConfig := []byte(fmt.Sprintf(`{"Config":{"Image":"%s"}}`, id))