Merge branch 'master' of https://github.com/GoogleContainerTools/skaf…

…fold into ns-flag

.gitignore

@@ -1,3 +1,4 @@
+bin/
 out/
 examples/bazel/bazel-*
 integration/examples/bazel/bazel-*

.travis.yml

@@ -21,19 +21,12 @@ jobs:
       name: "Linux unit"
       script:
         - make
-        - make quicktest
-      after_success:
-        - bash <(curl -s https://codecov.io/bash)
+        - make coverage
     - os: osx
       name: "OSX unit"
-      env:
-        - GO111MODULE=on
-        - GOFLAGS="-mod=vendor"
       script:
-        - go build -o out/skaffold cmd/skaffold/skaffold.go
-        - go test -short -timeout 60s ./...
-      after_success:
-        - bash <(curl -s https://codecov.io/bash)
+        - make
+        - make quicktest
     - os: windows
       name: "Windows unit"
       env:

CHANGELOG.md

@@ -1,3 +1,87 @@
+# v0.37.0 Release - 08/29/2019
+
+No new features in this release!
+
+Bug Fixes:
+
+* Use active gcloud credentials for executing cloudbuild when available [#2731](https://github.com/GoogleContainerTools/skaffold/pull/2731)
+* Restore original images only if there are no remote manifests [#2746](https://github.com/GoogleContainerTools/skaffold/pull/2746)
+* List manifests in the order given by the user [#2729](https://github.com/GoogleContainerTools/skaffold/pull/2729)
+* Fix 'skaffold diagnose' for custom builder without dependencies [#2724](https://github.com/GoogleContainerTools/skaffold/pull/2724)
+* Don't panic when dockerConfig isn't provided [#2735](https://github.com/GoogleContainerTools/skaffold/pull/2735)
+* Don't set KanikoArtifact if CustomArtifact is set [#2716](https://github.com/GoogleContainerTools/skaffold/pull/2716)
+* [Caching] Artifact’s config is an input to digest calculation [#2728](https://github.com/GoogleContainerTools/skaffold/pull/2728)
+* Don’t fetch images that are aliases for scratch [#2720](https://github.com/GoogleContainerTools/skaffold/pull/2720)
+* Implement exponential backoff for retrieving cloud build status [#2667](https://github.com/GoogleContainerTools/skaffold/pull/2667)
+* Fix call to newPortForwardEntry constructor in kubectl_forwarder_test [#2703](https://github.com/GoogleContainerTools/skaffold/pull/2703)
+* Add information about top level owner to port forward key [#2675](https://github.com/GoogleContainerTools/skaffold/pull/2675)
+* Turn RPC State forwardedPorts into map keyed by the local port [#2659](https://github.com/GoogleContainerTools/skaffold/pull/2659)
+* Show the duration of the deploy phase [#2739](https://github.com/GoogleContainerTools/skaffold/pull/2739)
+* Configure jib.allowInsecureRegistries as required [#2674](https://github.com/GoogleContainerTools/skaffold/pull/2674)
+
+Updates & Refactors:
+
+* Pass extra env to the Docker CLI [#2737](https://github.com/GoogleContainerTools/skaffold/pull/2737)
+* Improve manifest splitting. [#2727](https://github.com/GoogleContainerTools/skaffold/pull/2727)
+* Bazel query should specify --output [#2712](https://github.com/GoogleContainerTools/skaffold/pull/2712)
+* Print the output of failed integration tests [#2725](https://github.com/GoogleContainerTools/skaffold/pull/2725)
+* We must handle every profile field type [#2726](https://github.com/GoogleContainerTools/skaffold/pull/2726)
+* Fix CI scripts [#2736](https://github.com/GoogleContainerTools/skaffold/pull/2736)
+* Directs "Download" button to Quickstart [#2695](https://github.com/GoogleContainerTools/skaffold/pull/2695)
+* Small improvements to code coverage [#2719](https://github.com/GoogleContainerTools/skaffold/pull/2719)
+* Don’t store log lines as mutable slices of bytes [#2721](https://github.com/GoogleContainerTools/skaffold/pull/2721)
+* more debugging for kubectl portforward [#2707](https://github.com/GoogleContainerTools/skaffold/pull/2707)
+* Remove time sensitive tests [#2655](https://github.com/GoogleContainerTools/skaffold/pull/2655)
+* Log a warning and rebuild if needed when caching fails [#2685](https://github.com/GoogleContainerTools/skaffold/pull/2685)
+* Improve logging warning when enountering profile field of unhandled type [#2691](https://github.com/GoogleContainerTools/skaffold/pull/2691)
+* refactor: Add upgrade utility to handle all pipelines in a SkaffoldConfig [#2582](https://github.com/GoogleContainerTools/skaffold/pull/2582)
+* Add struct for generate_pipeline to keep track of related data [#2686](https://github.com/GoogleContainerTools/skaffold/pull/2686)
+* Add unit tests to kubectl forwarder [#2661](https://github.com/GoogleContainerTools/skaffold/pull/2661)
+* separate checks + unit tests [#2676](https://github.com/GoogleContainerTools/skaffold/pull/2676)
+* Add UPSTREAM_CLIENT_TYPE user agent environment variable to kaniko pod [#2723](https://github.com/GoogleContainerTools/skaffold/pull/2723)
+
+Docs: 
+
+* Document Docker buildArgs as templated field [#2696](https://github.com/GoogleContainerTools/skaffold/pull/2696)
+* Update cache-artifacts option usage language to reflect new default [#2711](https://github.com/GoogleContainerTools/skaffold/pull/2711)
+* docs: clarify that tagged images in manifests are not replaced [#2598](https://github.com/GoogleContainerTools/skaffold/pull/2598)
+* fix development guide link [#2710](https://github.com/GoogleContainerTools/skaffold/pull/2710)
+* Update community section of README [#2682](https://github.com/GoogleContainerTools/skaffold/pull/2682)
+
+Huge thanks goes out to all of our contributors for this release:
+
+- Aaron Paz
+- Andreas Sommer
+- Appu
+- Balint Pato
+- bpopovschi
+- Brian de Alwis
+- Cedric Kring
+- Chanseok Oh
+- Charles-Henri GUERIN
+- Cornelius Weig
+- David Gageot
+- Dmitri Moore
+- Filip Krakowski
+- Jason McClellan
+- JieJhih Jhang
+- Marlon Gamez
+- Matt Brown
+- Medya Ghazizadeh
+- Michael Beaumont
+- Nick Kubala
+- Prashant Arya
+- Priya Wadhwa
+- Russell Wolf
+- Sébastien Le Gall
+- Sergei Morozov
+- Tad Cordle
+- Tanner Bruce
+- Taylor Barrella
+- Tejal Desai
+- Tom Dickman
+
+
 # v0.36.0 Release - 08/15/2019
 
 New Features:

DEVELOPMENT.md

@@ -119,7 +119,7 @@ To build with your local changes you have two options:
 If you are iterating on skaffold and want to see your changes in action, you can:
 
 1. [Build skaffold](#building-skaffold)
-2. [Use the quickstart example](README.md#iterative-development)
+2. [Use the quickstart example](examples/getting-started/README.md)
 
 ## Testing skaffold
 

Makefile

@@ -100,6 +100,13 @@ cross: $(foreach platform, $(SUPPORTED_PLATFORMS), $(BUILD_DIR)/$(PROJECT)-$(pla
 .PHONY: test
 test: $(BUILD_DIR)
 	@ ./hack/test.sh
+	@ ./hack/checks.sh
+
+.PHONY: coverage
+coverage: $(BUILD_DIR)
+	@ ./hack/test.sh
+	@ curl -s https://codecov.io/bash > $(BUILD_DIR)/upload_coverage
+	@ bash $(BUILD_DIR)/upload_coverage
 
 .PHONY: checks
 checks: $(BUILD_DIR)

cmd/skaffold/app/cmd/flags.go

@@ -82,7 +82,7 @@ var FlagRegistry = []Flag{
 	},
 	{
 		Name:          "cache-artifacts",
-		Usage:         "Set to true to enable caching of artifacts",
+		Usage:         "Set to false to disable default caching of artifacts",
 		Value:         &opts.CacheArtifacts,
 		DefValue:      true,
 		FlagAddMethod: "BoolVar",

docs/config.toml

@@ -70,7 +70,7 @@ weight = 1
 #copyright = "Skaffold"
 #privacy_policy = "https://policies.google.com/privacy"
 github_repo = "https://github.com/GoogleContainerTools/skaffold"
-skaffold_version = "skaffold/v1beta13"
+skaffold_version = "skaffold/v1beta14"
 
 # Google Custom Search Engine ID. Remove or comment out to disable search.
 gcs_engine_id = "013756393218025596041:3nojel67sum"

docs/content/en/_index.html

@@ -9,8 +9,8 @@
 	<a class="btn btn-lg btn-primary mr-3 mb-4" href="{{< relref "/docs" >}}">
 		Learn More <i class="fas fa-arrow-alt-circle-right ml-2"></i>
 	</a>
-	<a class="btn btn-lg btn-secondary mr-3 mb-4" href="https://github.com/GoogleContainerTools/skaffold">
-		Download <i class="fab fa-github ml-2 "></i>
+	<a class="btn btn-lg btn-secondary mr-3 mb-4" href="https://skaffold.dev/docs/getting-started/#installing-skaffold">
+		Download <i class="fas fa-download ml-2 "></i>
 	</a>
 	<div class="mx-auto mt-5">
 		{{< blocks/link-down color="info" >}}

docs/content/en/docs/how-tos/deployers/_index.md

@@ -9,7 +9,7 @@ to deploy your app to a Kubernetes cluster.
 
 When Skaffold deploys an application the following steps happen:
 
-* the Skaffold deployer _renders_ the final kubernetes manifests: Skaffold replaces the image names in the kubernetes manifests with the final tagged image names.
+* the Skaffold deployer _renders_ the final kubernetes manifests: Skaffold replaces untagged image names in the kubernetes manifests with the final tagged image names.
 Also, in case of the more complicated deployers the rendering step involves expanding templates (in case of helm) or calculating overlays (in case of kustomize).
 * the Skaffold deployer _deploys_ the final kubernetes manifests to the cluster
 

docs/content/en/docs/how-tos/templating/_index.md

@@ -14,6 +14,7 @@ will be `gcr.io/k8s-skaffold/example:v1`.
 
 List of fields that support templating:
 
+* `build.artifacts.[].docker.buildArgs` (see [builders](/docs/how-tos/builders/))
 * `build.tagPolicy.envTemplate.template` (see [envTemplate tagger](/docs/how-tos/taggers/##envtemplate-using-values-of-environment-variables-as-tags))
 * `deploy.helm.releases.setValueTemplates` (see [Deploying with helm](/docs/how-tos/deployers/#deploying-with-helm))
 

docs/content/en/docs/references/cli/_index.md

@@ -116,7 +116,7 @@ Examples:
 
 Options:
   -b, --build-image=[]: Choose which artifacts to build. Artifacts with image names that contain the expression will be built only. Default is to build sources for all artifacts
-      --cache-artifacts=true: Set to true to enable caching of artifacts
+      --cache-artifacts=true: Set to false to disable default caching of artifacts
       --cache-file='': Specify the location of the cache file (default $HOME/.skaffold/cache)
   -c, --config='': File for global configurations (defaults to $HOME/.skaffold/config)
   -d, --default-repo='': Default repository value (overrides global config)
@@ -287,7 +287,7 @@ Run a pipeline in debug mode
 
 
 Options:
-      --cache-artifacts=true: Set to true to enable caching of artifacts
+      --cache-artifacts=true: Set to false to disable default caching of artifacts
       --cache-file='': Specify the location of the cache file (default $HOME/.skaffold/cache)
       --cleanup=true: Delete deployments after dev or debug mode is interrupted
   -c, --config='': File for global configurations (defaults to $HOME/.skaffold/config)
@@ -429,7 +429,7 @@ Run a pipeline in development mode
 
 
 Options:
-      --cache-artifacts=true: Set to true to enable caching of artifacts
+      --cache-artifacts=true: Set to false to disable default caching of artifacts
       --cache-file='': Specify the location of the cache file (default $HOME/.skaffold/cache)
       --cleanup=true: Delete deployments after dev or debug mode is interrupted
   -c, --config='': File for global configurations (defaults to $HOME/.skaffold/config)
@@ -594,7 +594,7 @@ Examples:
   skaffold run -p <profile>
 
 Options:
-      --cache-artifacts=true: Set to true to enable caching of artifacts
+      --cache-artifacts=true: Set to false to disable default caching of artifacts
       --cache-file='': Specify the location of the cache file (default $HOME/.skaffold/cache)
       --cleanup=true: Delete deployments after dev or debug mode is interrupted
   -c, --config='': File for global configurations (defaults to $HOME/.skaffold/config)