Take feedback into account

Signed-off-by: David Gageot <david@gageot.net>
GoogleContainerTools · Oct 16, 2018 · d52600f · d52600f
1 parent 7e79003
commit d52600f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/examples/annotated-skaffold.yaml b/examples/annotated-skaffold.yaml
@@ -63,7 +63,7 @@ build:
 
     # jibMaven builds containers using the Jib plugin for Maven.
     # jibMaven:
-    #  module: modulename     # selects which maven module to build
+    #  module: modulename     # selects which maven module to build, for a multimodule project
     #  profile: profilename   # selects which maven profile to activate
 
     # jibGradle builds containers using the Jib plugin for Gradle.

diff --git a/examples/jib/pom.xml b/examples/jib/pom.xml
@@ -39,6 +39,8 @@
                     <container>
                         <jvmFlags>
                             <jvmFlag>-Djava.security.egd=file:/dev/./urandom</jvmFlag>
+                            <jvmFlag>-XX:+UnlockExperimentalVMOptions</jvmFlag>
+                            <jvmFlag>-XX:+UseCGroupMemoryLimitForHeap</jvmFlag>
                         </jvmFlags>
                     </container>
                 </configuration>

diff --git a/integration/examples/annotated-skaffold.yaml b/integration/examples/annotated-skaffold.yaml
@@ -63,7 +63,7 @@ build:
 
     # jibMaven builds containers using the Jib plugin for Maven.
     # jibMaven:
-    #  module: modulename     # selects which maven module to build
+    #  module: modulename     # selects which maven module to build, for a multimodule project
     #  profile: profilename   # selects which maven profile to activate
 
     # jibGradle builds containers using the Jib plugin for Gradle.

diff --git a/integration/examples/jib/pom.xml b/integration/examples/jib/pom.xml
@@ -39,6 +39,8 @@
                     <container>
                         <jvmFlags>
                             <jvmFlag>-Djava.security.egd=file:/dev/./urandom</jvmFlag>
+                            <jvmFlag>-XX:+UnlockExperimentalVMOptions</jvmFlag>
+                            <jvmFlag>-XX:+UseCGroupMemoryLimitForHeap</jvmFlag>
                         </jvmFlags>
                     </container>
                 </configuration>