Skip to content

Commit

Permalink
Restart the dev loop when the skaffold config changes (#2347)
Browse files Browse the repository at this point in the history
I thought I fixed that recently but it turns out I
haven’t!

Move default labeller to deploy since it used in deployer.
  • Loading branch information
dgageot authored Jun 26, 2019
1 parent 926ebce commit 5a3a529
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion cmd/skaffold/app/cmd/dev.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

"github.com/GoogleContainerTools/skaffold/pkg/skaffold/runner"
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/latest"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
Expand Down Expand Up @@ -85,7 +86,11 @@ func doDev(ctx context.Context, out io.Writer) error {
return err
})
if err != nil {
return err
if errors.Cause(err) != runner.ErrorConfigurationChanged {
return err
}
// Otherwise, the skaffold config has changed.
// just recreate a new runner and restart a dev loop
}
}
}
Expand Down

0 comments on commit 5a3a529

Please sign in to comment.