Merge pull request #2136 from dgageot/fix-yoda-condition

Fix yoda condition
GoogleContainerTools · May 16, 2019 · 14436d7 · 14436d7
2 parents 17f7009 + 58d6a78
commit 14436d7
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/cmd/skaffold/app/flags/build_output_test.go b/cmd/skaffold/app/flags/build_output_test.go
@@ -96,15 +96,7 @@ func TestBuildOutputSet(t *testing.T) {
 
 func TestBuildOutputString(t *testing.T) {
 	flag := NewBuildOutputFileFlag("test.in")
-	if "test.in" != flag.String() {
-		t.Errorf("Flag String() does not match. Expected test.in, Actual %s", flag.String())
-	}
-}
 
-func TestBuildOutputType(t *testing.T) {
-	flag := NewBuildOutputFileFlag("test.in")
-	expectedFlagType := "*flags.BuildOutputFileFlag"
-	if flag.Type() != expectedFlagType {
-		t.Errorf("Flag returned wrong type. Expected %s, Actual %s", expectedFlagType, flag.Type())
-	}
+	testutil.CheckDeepEqual(t, "test.in", flag.String())
+	testutil.CheckDeepEqual(t, "*flags.BuildOutputFileFlag", flag.Type())
 }