Fix SIGSEGV on file system deletion while building #765
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
pkg/util/fs_util.go
Outdated
| @@ -137,6 +141,13 @@ func DeleteFilesystem() error { | |||
| return os.RemoveAll(path) | |||
| }) | |||
| } | |||
| // isExists returns tru if path exists | |||
pkg/util/fs_util.go
Outdated
| @@ -121,6 +121,10 @@ func DeleteFilesystem() error { | |||
| logrus.Info("Deleting filesystem...") | |||
| return filepath.Walk(constants.RootDir, func(path string, info os.FileInfo, _ error) error { | |||
| if CheckWhitelist(path) { | |||
| if ! isExist(path) { | |||
| logrus.Debugf("Path %s whitelisted, but not exists", path) | |||
There was a problem hiding this comment.
nit: double space after Path
pkg/util/fs_util.go
Outdated
| @@ -121,6 +121,10 @@ func DeleteFilesystem() error { | |||
| logrus.Info("Deleting filesystem...") | |||
| return filepath.Walk(constants.RootDir, func(path string, info os.FileInfo, _ error) error { | |||
| if CheckWhitelist(path) { | |||
| if ! isExist(path) { | |||
There was a problem hiding this comment.
this needs to be run through gofmt to get travis to pass
|
@Onlinehead Thanks for the fix. Is there a workaround until this gets merged? or is there something to do to speedup the process of releasing it? @jonjohnsonjr |
Fix issue #756
That error happens only if you have files/directories inside a path marked as
VOLUMEWhitelisting and delete functions don't expect you have something inside a VOLUME path and deleting content inside that dir (which is a correct behavior) breaks processing files inside the dir.
The fix adds
isExistscheck for file/directory beforeinfo.IsDir()and skip path processing if it is not exist.