Include warmer in debug image #497
Conversation
|
Hi @warrenseymour. Thanks for your PR. I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hey @warrenseymour, everything looks good to me in the PR. Once you rebase to fix the merge conflicts, I'll go ahead and merge this PR. Thanks! |
|
@warrenseymour Do you need some help rebasing this? |
|
@warrenseymour: would like for you to complete this. |
|
Sorry folks, had totally forgotten about this. I'll get this mergable this afternoon. |
When using Kaniko with certain build systems, such as GitLab CI, it is necessary to use the 'debug' image and override the entrypoint, so that an arbitrary build script can be executed within the container. Unfortunately, the 'warmer' binary is not available in the 'debug' image, making it impossible to perform a base image cache warmup using such build systems. This patch addresses this by ensuring that the 'out/warmer' target is made in the initial stage, and that all 'out' files are copied to '/kaniko' in the final stage.
wms
force-pushed
the
include-warmer-in-debug-image
branch
from
cbe1520
to
319bfde
Compare
|
Rebased and ready for re-review |
|
I've also updated |
|
@sharifelgamal is there anything blocking this? |
|
@mamoit thanks for the PR! |
|
@tejal29 It was not mine :) it was @warrenseymour. |
When using Kaniko with certain build systems, such as GitLab CI, it is necessary to use the 'debug' image and override the entrypoint, so that an arbitrary build script can be executed within the container. Unfortunately, the 'warmer' binary is not available in the 'debug' image, making it impossible to perform a base image cache warmup using such build systems.
This patch addresses this by ensuring that the 'out/warmer' target is made in the initial stage, and that all 'out' files are copied to '/kaniko' in the final stage.
If anybody wants to make use of this change before its merged, I've pushed an image to Docker Hub named
fountainheadtech/kaniko:debug-warmer.