Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docker #2440

Merged
merged 9 commits into from
Mar 24, 2023
Merged

Conversation

joe-kimmel-vmw
Copy link
Contributor

@joe-kimmel-vmw joe-kimmel-vmw commented Mar 23, 2023

Upgrades docker version (should close #2370 after merging)

Description

Turns out Cloud Native Buildpacks, downstream of yall, would really like to upgrade our docker version, but that's goingt o be easier if you-all do it too. I think this is basically because golang likes to pretend we all work in a monorepo of a certain larGe co. where all deps get bumped at once?

Note - I want to make this PR,- there's still 2 unit tests failing locally that seem unrelated (one of them wants GCP creds? and one of them I can't figure out why it's failing), anyways I want to see how much of the unit test suite passes in CI and whether there's other tests that need to be fixed in integration land.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [x ] Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

bumps docker to v23 and updates many other libraries as well.

@google-cla
Copy link

google-cla bot commented Mar 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
…are still failing

Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
…the file

Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@imjasonh imjasonh merged commit 906cc96 into GoogleContainerTools:main Mar 24, 2023
@joe-kimmel-vmw joe-kimmel-vmw deleted the upgrade-docker2 branch March 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants