-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Integration tests #2425
Merged
Merged
Fix Integration tests #2425
Commits on Feb 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ce2b8f8 - Browse repository at this point
Copy the full SHA ce2b8f8View commit details
Commits on Mar 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1a9cd4c - Browse repository at this point
Copy the full SHA 1a9cd4cView commit details -
chore(lint): fix linter issues
- Adapted error comparison according to linter recommendation - Disabled noctx linting for http request where canceling makes no sense - Disabled nilerror linting where nil error is returned on purpose - Disabled makezero linter where slice is explicitly deepcopied
Configuration menu - View commit details
-
Copy full SHA for 92ce78c - Browse repository at this point
Copy the full SHA 92ce78cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06ed647 - Browse repository at this point
Copy the full SHA 06ed647View commit details
Commits on Mar 10, 2023
-
fix(ci): Allow boilerplate years from 2000-2099
Previously the regex only allowed the copyright notice to contain the years 2018,2019,2020,2021, or 2022. This commit widens to regex to 20\d\d allowing any year in the range [2000-2099]
Configuration menu - View commit details
-
Copy full SHA for d68e5bc - Browse repository at this point
Copy the full SHA d68e5bcView commit details -
feat(ci): Replace minikube with k3s for intregration tests
The existing setup for minikube is very complicated, replicating most of the setup steps for a full kubernetes cluster in an only partially supported minikube configuration (driver=none). Furthermore the existing setup has been broken for sometime, likely, at least in part due to the changes to CNI and CRI in recent kubernetes versions. Since what we actually need is only a running Kubernetes cluster on the node and access to a registry on localhost:5000, we can switch the extremely complicated minikube setup for a lightweight cluster using k3s. Minikube came with a default addon for running a registry on every node, but the same is not the case for k3s, instead we make use of the package helm controller and its HelmChart CR to deploy twuni/docker-registry.helm and expose it on localhost using the integrated LoadBalancer controller.
Configuration menu - View commit details
-
Copy full SHA for 9334ef9 - Browse repository at this point
Copy the full SHA 9334ef9View commit details
Commits on Mar 20, 2023
-
fix(test-684): pin base container version
The dockerfile for the regression test connected to issue 684 used a rolling tag as base image, making it flaky and fail since it was introduced. This commit pins the base image to the digest of bionic-20200219, which, based on the date of the commit that introduced to the dockerfile would be the most newest ubuntu build and likely what the "rolling" tag resolved to back then. Since this also an image from the pre-oci days of ubuntu, this circumvents a bug in container-diff as well (GoogleContainerTools/container-diff#389)
Configuration menu - View commit details
-
Copy full SHA for 1dbe685 - Browse repository at this point
Copy the full SHA 1dbe685View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.