Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle platforms that include CPU variants #1929

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Correctly handle platforms that include CPU variants #1929

merged 2 commits into from
Feb 10, 2022

Commits on Feb 7, 2022

  1. Correctly handle platforms that include CPU variants 

    Prior to this change, Kaniko would only select the platform-specific
image from a multi-platform image using the OS and architecture to
select the image. This leads to problems when there are two platforms
that are indistinguishable using only this information (e.g.,
linux/arm/v5 and linux/arm/v7).

This change more explicitly selects the right image from a
multi-platform image, taking CPU variant into account (v5 vs v7), using
containerd's CPU variant detection logic.

This also moves platform defaulting up as early as possible in execution
as it can go, so that malformed platform values are detected as soon as
possible.
    @imjasonh
    imjasonh committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    6ac4367 View commit details
    Browse the repository at this point in the history

  2. set platform in unit test

    @imjasonh
    imjasonh committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    bf2769a View commit details
    Browse the repository at this point in the history