Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deploy/cloudbuild-*.yaml files #1907

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

imjasonh
Copy link
Collaborator

As far as I can tell, these are unnecessary, since the equivalent build+push workflows are configured in GitHub Actions. I don't know at what point these became redundant, maybe someone else knows. @priyawadhwa do you know?

In any case, if they are in fact redundant, we should remove them before pushing another release, or else we may get a confusing race condition when pushing if the images aren't fully reproducible for some reason.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Remove cloudbuild.yaml configs to build images; images are released using GitHub Actions.

@priyawadhwa
Copy link
Collaborator

My guess is that it was just accidentally left behind!

@imjasonh imjasonh merged commit bde9043 into GoogleContainerTools:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants