Attempt to fix erroneous build cancellation #1867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on #1858
The theory is that having the concurrency config inside
build-images
means that each matrix value shares the same concurrency key. If that's the case, the only reason this works at all is that there's some race where tasks that start at the ~same enough time won't cancel each other, but when they start minutes apart, they cancel previously started runs.With this change, the concurrency key is based on the matrix value, so they should be unique per
image x PR-or-commit
, and not conflict and cancel previous runs.Another option would be to move the concurrency config back up to the top level, which would also work (if the theory of what's happening is right), but would mean that there's one large concurrency lock around "building images" and not four fine-grained ones around "building each image", which I think is slightly better -- and will become even better when/if we can get image builds to not take 30+ minutes. 🐢
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes