Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document flags for tarball build only #1503

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Document flags for tarball build only #1503

merged 1 commit into from
Dec 9, 2020

Conversation

ltoenning
Copy link
Contributor

@ltoenning ltoenning commented Nov 23, 2020

Description

If only --tarPath and --destination are set (--destination must be set for --tarPath, see #572) the image will also be pushed to destination. This fixes the documentation which states that with --tarPath the image is saved instead of pushed.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@google-cla
Copy link

google-cla bot commented Nov 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Nov 23, 2020
@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Nov 23, 2020
@tejal29 tejal29 merged commit 5fad5f3 into GoogleContainerTools:master Dec 9, 2020
somdoron added a commit to somdoron/action-kaniko that referenced this pull request Jun 8, 2021
Kaniko default behavior changed, `--tarPath` alone is not enough to skip the push to registery, `--no-push` is now required as well.

Reference:
GoogleContainerTools/kaniko#1503
somdoron added a commit to somdoron/action-kaniko that referenced this pull request Jun 8, 2021
Kaniko default behavior changed, `--tarPath` alone is not enough to skip the push to registry, `--no-push` is now required as well.

Reference:
GoogleContainerTools/kaniko#1503
somdoron added a commit to somdoron/action-kaniko that referenced this pull request Jun 8, 2021
Kaniko default behavior changed, `--tarPath` alone is not enough to skip the push to registry, `--no-push` is now required as well.

Reference:
GoogleContainerTools/kaniko#1503
aexvir pushed a commit to aevea/action-kaniko that referenced this pull request Sep 21, 2021
Kaniko default behavior changed, `--tarPath` alone is not enough to skip the push to registry, `--no-push` is now required as well.

Reference:
GoogleContainerTools/kaniko#1503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants