Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DOCKER_CONFIG to be a filename #1409

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Allow DOCKER_CONFIG to be a filename #1409

merged 2 commits into from
Sep 30, 2020

Conversation

akram
Copy link
Contributor

@akram akram commented Aug 31, 2020

Fixes #1407

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Aug 31, 2020
@akram akram force-pushed the fallback-dockerconfig branch 6 times, most recently from 925b01e to 0eac808 Compare August 31, 2020 23:53
tejal29
tejal29 requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @akram for your PR.

Can you please add a test to point DOCKER_CONFIG to a file location e.g. tmpXXX/docker.conf and make sure the func DockerConfLocation return the file.

pkg/executor/push_test.go Outdated Show resolved Hide resolved
pkg/executor/push_test.go Outdated Show resolved Hide resolved
@akram akram force-pushed the fallback-dockerconfig branch 2 times, most recently from ab2148a to df5107b Compare September 29, 2020 10:09
@akram
Copy link
Contributor Author

akram commented Sep 29, 2020

hi @tejal29 can PTAL ?

@akram akram force-pushed the fallback-dockerconfig branch 2 times, most recently from 8606be8 to 87f259f Compare September 29, 2020 16:31
@akram akram requested a review from tejal29 September 29, 2020 16:41
@akram akram force-pushed the fallback-dockerconfig branch 2 times, most recently from fd3b4c4 to 612994c Compare September 29, 2020 20:33
@akram
UnitTest: DockerConfLocation must return a file if it is existent and…
013de40 
… passed using env, or default if the file is incorrect
@tejal29 tejal29 merged commit ab768b5 into GoogleContainerTools:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify an alternative path to .docker/config.json e.g .dockercfg
3 participants
@akram @tejal29 @googlebot