Make cloudbuild.yaml re-usable for anyone #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud build is also really useful for devs that have limited resources to build Kaniko locally. This commit makes adds parameters to cloudbuild to make it easy to adjust to your own project.
Cloud build requires vendors directory to be uploaded when using a build submitted from local directory. However .gcloudignore prevents the vendor directory to be uploaded and causes issues.
tejal29
requested changes
Mar 16, 2020
| @@ -2,18 +2,21 @@ steps: | |||
| # First, build kaniko | |||
| - name: "gcr.io/cloud-builders/docker" | |||
| args: ["build", "-f", "deploy/Dockerfile", | |||
| "-t", "gcr.io/kaniko-project/executor:${COMMIT_SHA}", "."] | |||
There was a problem hiding this comment.
We would need to change the trigger in kaniko Project to set PROJECT_ID to "kaniko-project" along with this change?
Can you please test the trigger which used this file after adding this substitution value
https://pantheon.corp.google.com/cloud-build/triggers/edit/0539d73e-5ccf-46e7-af5a-6f857f99c871?project=kaniko-project
There was a problem hiding this comment.
$PROJECT_ID will automatically be the current project that the cloud build is executing in. Does cloud build trigger run in the project kaniko-project?
There was a problem hiding this comment.
yes!. Great thanks for confirming.
tejal29
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud build is also really useful for devs that have limited resources
to build Kaniko locally. This commit makes adds parameters to cloudbuild
to make it easy to adjust to your own project.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes