Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dockerfile.dockerignore #776

Closed
victornoel opened this issue Sep 17, 2019 · 4 comments · Fixed by #801
Closed

Support Dockerfile.dockerignore #776

victornoel opened this issue Sep 17, 2019 · 4 comments · Fixed by #801
Labels
area/performance issues related to kaniko performance enhancement kind/enhancement New feature or request priority/p2 High impact feature/bug. Will get a lot of users happy

Comments

@victornoel
Copy link
Contributor

Currently kaniko only looks for a .dockerignore file but a uselful feature of docker build is to take <path/to/Dockerfile>.dockerignore into account if it exists.

See moby/buildkit#901
@tejal29 tejal29 added area/performance issues related to kaniko performance enhancement kind/enhancement New feature or request priority/p2 High impact feature/bug. Will get a lot of users happy labels Sep 20, 2019
@tejal29
Copy link
Member

tejal29 commented Oct 2, 2019

Thanks @victornoel would you be up for submitting an PR for this?
You would need to consider the opts.DockerfilePath here along with the opts.SrcContext if DockerfilePath is not a remote file.

https://github.com/GoogleContainerTools/kaniko/blob/master/pkg/executor/build.go#L430

@victornoel
Copy link
Contributor Author

@tejal29 thx, I'm trying but I'm blocked by #798 :)

victornoel added a commit to victornoel/kaniko that referenced this issue Oct 3, 2019
@victornoel
Fix GoogleContainerTools#776
d9e7fa4
@victornoel victornoel mentioned this issue Oct 3, 2019
Merged
4 tasks
victornoel added a commit to victornoel/kaniko that referenced this issue Oct 3, 2019
@victornoel
Fix GoogleContainerTools#776
7a6f4b9
@victornoel
Copy link
Contributor Author

@tejal29 I've made a PR, I will leave the integration tests execution to the CI :)

victornoel added a commit to victornoel/kaniko that referenced this issue Oct 3, 2019
@victornoel
Fix GoogleContainerTools#776
db12a77
@tejal29
Copy link
Member

tejal29 commented Oct 4, 2019

Thanks @victornoel. Please try reverting go to v12, and try running make integration

victornoel added a commit to victornoel/kaniko that referenced this issue Oct 4, 2019
@victornoel
Add more tests for GoogleContainerTools#776
5700de0
victornoel added a commit to victornoel/kaniko that referenced this issue Oct 4, 2019
@victornoel
Fix integration tests for GoogleContainerTools#776
ff7abba
@bard bard mentioned this issue Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance issues related to kaniko performance enhancement kind/enhancement New feature or request priority/p2 High impact feature/bug. Will get a lot of users happy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Dockerfile.dockerignore victornoel/kaniko
2 participants
@victornoel @tejal29