Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--skip-tls-verify option is not used on checking push permission #628

Closed
zhleonix opened this issue Mar 28, 2019 · 1 comment · Fixed by #663
Closed

--skip-tls-verify option is not used on checking push permission #628

zhleonix opened this issue Mar 28, 2019 · 1 comment · Fixed by #663

Comments

@zhleonix
Copy link

Actual behavior
When checking push permission, the --skip-tls-verify options are not used, which causes failed operation on our private registry without importing root cert into the kaniko image.:
error checking push permissions -- make sure you entered the correct tag name, and that you are authenticated correctly, and try again: checking push permission for "private.repo/test/kaniko_demo:latest": Get https://private.repo/v2/: x509: certificate signed by unknown authority

Expected behavior
--skip-tls-verify should be considered even on CheckPushPermissions.

To Reproduce
Steps to reproduce the behavior:

  1. Use an internal private repository without valid public certs
  2. Use kaniko to build the image and push it to private repository
  3. Before push, kaniko checks the permission but cannot verify its certificate

Additional Information
latest version on master branch
zhleonix added a commit to zhleonix/kaniko that referenced this issue Mar 28, 2019
@zhleonix
Fix checking push permission without skipping tls on configured (Goog…
a3ea830 
…leContainerTools#628)
zhleonix added a commit to zhleonix/kaniko that referenced this issue Mar 28, 2019
@zhleonix
Fix checking push permission without skipping tls on configured (Goog…
4013f2e 
…leContainerTools#628)
@lolychee
Copy link

--insecure also not work

abergmeier pushed a commit to abergmeier/kaniko that referenced this issue May 15, 2019
@AndreasBergmeier6176
Add SkipVerify support to CheckPushPermissions.
9644871 
Extract makeTransport, which allows using the current mechanism used for
pushing.

Fixes GoogleContainerTools#628.
@abergmeier abergmeier mentioned this issue May 15, 2019
Merged
sharifelgamal pushed a commit that referenced this issue Jun 14, 2019
@abergmeier @sharifelgamal
Add SkipVerify support to CheckPushPermissions. (#663)
7cc899b 
Extract makeTransport, which allows using the current mechanism used for
pushing.

Fixes #628.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SkipVerify support to CheckPushPermissions. abergmeier/kaniko
2 participants
@lolychee @zhleonix