Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target stage lookup should be case insensitive #2046

Closed
hypnoce opened this issue Apr 12, 2022 · 0 comments · Fixed by #2047
Closed

Target stage lookup should be case insensitive #2046

hypnoce opened this issue Apr 12, 2022 · 0 comments · Fixed by #2047

Comments

@hypnoce
Copy link
Contributor

hypnoce commented Apr 12, 2022

Actual behavior
Given the Dockerfile

FROM scratch AS UPPER_CASE
RUN echo "UPPER_CASE target works !"

The command

./executor build [...] --target UPPER_CASE

exits with error UPPER_CASE is not a valid target build stage

Expected behavior
Build should complete successfully (like docker build).

Additional Information

  • Dockerfile
    See above
  • Build Context
    No build context

Triage Notes for the Maintainers

Description Yes/No
Please check if this a new feature you are proposing
Please check if the build works in docker but not in kaniko
Please check if this error is seen when you use --cache flag
Please check if your dockerfile is a multistage dockerfile
hypnoce added a commit to hypnoce/kaniko that referenced this issue Apr 12, 2022
@hypnoce
Fixes GoogleContainerTools#2046: make target stage lookup case insens…
723a67a 
…itive
@hypnoce hypnoce mentioned this issue Apr 12, 2022
Merged
4 tasks
imjasonh pushed a commit that referenced this issue Apr 12, 2022
@hypnoce
Fixes #2046: make target stage lookup case insensitive (#2047)
f9c5745
chuangw6 added a commit that referenced this issue Jun 1, 2022
@chuangw6
Release v1.9.0
5016275 
Highlights
- Installed binaries are missing from image [#2049](#2049)
- proc: detect kubernetes runtime by mounts [#2054](#2054)
- Fixes #2046: make target stage lookup case insensitive [#2047](#2047)
- fix: Refactor LayersMap to correct old strange code behavior [#2066](#2066)
- Fix missing setuid flags on COPY --from=build operation [#2089](#2089)
- Fixes #2046: make target stage lookup case insensitive [#2047](#2047)
- Add GitLab CI credentials helper [#2040]((#2040))
- and a number of dependency bumps
chuangw6 added a commit that referenced this issue Jun 1, 2022
@chuangw6
Release v1.9.0
c0beb46 
Highlights
- Installed binaries are missing from image #2049
- proc: detect kubernetes runtime by mounts #2054
- Fixes #2046: make target stage lookup case insensitive #2047
- Fix: Refactor LayersMap to correct old strange code behavior #2066
- Fix missing setuid flags on COPY --from=build operation #2089
- Fixes #2046: make target stage lookup case insensitive #2047
- Add GitLab CI credentials helper #2040
- And a number of dependency bumps
chuangw6 added a commit that referenced this issue Aug 9, 2022
@chuangw6
Release v1.9.0
2201b6f 
Highlights
- Installed binaries are missing from image #2049
- proc: detect kubernetes runtime by mounts #2054
- Fixes #2046: make target stage lookup case insensitive #2047
- Fix: Refactor LayersMap to correct old strange code behavior #2066
- Fix missing setuid flags on COPY --from=build operation #2089
- Fixes #2046: make target stage lookup case insensitive #2047
- Add GitLab CI credentials helper #2040
- And a number of dependency bumps
chuangw6 added a commit that referenced this issue Aug 10, 2022
@chuangw6
Release v1.9.0 (#2117)
a8498c7 
Highlights
- Installed binaries are missing from image #2049
- proc: detect kubernetes runtime by mounts #2054
- Fixes #2046: make target stage lookup case insensitive #2047
- Fix: Refactor LayersMap to correct old strange code behavior #2066
- Fix missing setuid flags on COPY --from=build operation #2089
- Fixes #2046: make target stage lookup case insensitive #2047
- Add GitLab CI credentials helper #2040
- And a number of dependency bumps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2046: make target stage lookup case insensitive hypnoce/kaniko
1 participant
@hypnoce