Infers common credential helper names from target registry. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should release v0.1.1 after this is merged. |
Closed
elharo
approved these changes
Feb 7, 2018
…infer-credential-helper
loosebazooka
approved these changes
Feb 8, 2018
| } else if (registry.endsWith("amazonaws.com")) { | ||
| return "ecr-login"; | ||
| } | ||
| // TODO: Add more common credential helpers. |
There was a problem hiding this comment.
nit: this TODO seems unnecessary.
There was a problem hiding this comment.
This is mostly as a note to add more inferences such as Azure's -acr-* credential helpers. Is it standard practice to not have a note like this?
There was a problem hiding this comment.
Yeah, everyone uses them differently. I would think it's better to file a bug than leave this here, I tend to lose track of TODOs.
…infer-credential-helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20