Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'args' parameter to Maven plugin #361

Merged
merged 12 commits into from
Jun 4, 2018
Merged

Add 'args' parameter to Maven plugin #361

merged 12 commits into from
Jun 4, 2018

Conversation

TadCordle
Copy link
Contributor

After #360 because of Docker context stuff.

Fixes #346.

@TadCordle TadCordle changed the title Maven args Add 'args' parameter to Maven plugin Jun 4, 2018
@TadCordle TadCordle requested review from coollog and loosebazooka June 4, 2018 21:53
@@ -41,6 +41,7 @@
<to>
<image>gcr.io/jib-integration-testing/simpleimage:maven</image>
</to>
<args>An argument.</args>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know you could actually put it like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't either, it was an accident but it worked haha.

@TadCordle TadCordle merged commit 8a602c5 into master Jun 4, 2018
@TadCordle TadCordle deleted the maven_args branch June 4, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants