Implements Proposal: Address Base Image Reproducibility #245
Conversation
| LayerBuilder layerBuilder = | ||
| new LayerBuilder( | ||
| sourceFiles, extractionPath, buildConfiguration.getEnableReproducibleBuilds()); | ||
| LayerBuilder layerBuilder = new LayerBuilder(sourceFiles, extractionPath, true); |
There was a problem hiding this comment.
Is there any reason to keep this last parameter/reproducibility logic in LayerBuilder?
There was a problem hiding this comment.
I kept this here since the LayerBuilder is low-level logic, so the trade-off of removing the explicit "true" here would be a comment added to LayerBuilder saying that it only builds reproducibly.
There was a problem hiding this comment.
I think given that we're taking an "always reproducible" approach with jib now, it's implied that LayerBuilder will make reproducible layers, so I don't think we'd need to explicitly comment on that. Comment aside, I just don't think there's much use to keeping the internal enableReproducibleBuilds logic around if it isn't going to be used.
There was a problem hiding this comment.
Another option could be to rename LayerBuilder to ReproducibleLayerBuilder, if you want to be explicit.
There was a problem hiding this comment.
ReproducibleLayerBuilder sounds like a good idea
|
Should we move the proposal to "archives" or something as part of this PR? |
|
Yeah "archives" sounds like a good idea. |
https://github.com/GoogleContainerTools/jib/blob/master/proposals/reproducible_base_image.md
Fixes #241
Fixes #217