feat: --platform flag #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coopernetes
force-pushed
the
feat/multi-platform
branch
from
5edbbdd to
a34a657
Compare
|
looks good to me, I think there's some minor formatting issues? |
Good catch, should be fixed up now with |
coopernetes
force-pushed
the
feat/multi-platform
branch
2 times, most recently
from
88b64a3 to
20e1fc8
Compare
|
podman's been super flaky, I can't get it to startup properly, but hopefully #385 should fix that and you can rebase on that. |
|
Can we rebase now? And pull in that macos ci update |
- for images under test, pass the new --platform flag to pull the corresponding image if it is multi-platform capable - test execution via CreateContainerOptions passes in platform. If unset, will default to linux/amd64
gofmt tidy specify correct folder for platform tests
MacOS cannot run containers natively. M1/M2 defaults to linux/arm64 so the "os" field as part of --platform only needs to use linux/ as a default with GOARCH read in for the particular CPU architecture. Same deal with Windows, Docker on windows is virtualized Linux (AFAIU)
coopernetes
force-pushed
the
feat/multi-platform
branch
from
c5cef30 to
6d65644
Compare
|
Rebased, tests are passing again. @loosebazooka let me know if any other changes are needed. |
loosebazooka
approved these changes
Oct 18, 2023
|
This closed #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding image if it is multi-platform capable
unset, will default to linux/$GOARCH
Related: #373
This required a small enhancement from go-dockerclient via fsouza/go-dockerclient#1017. Updated go.mod was grabbed from the latest commit.
TODO: