Add stdout and stderr to JUnit test results #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Tested this on Jenkins, nice 👍
|
|
can you sign the CLA before we try to merge this? |
|
@ddl-pjohnson are you still able to help get this merged? |
ddl-pjohnson
force-pushed
the
pjohnson.add-stdout-and-stderr-to-junit
branch
from
925f574 to
b806867
Compare
|
@loosebazooka sorry for the delay, our company has now signed the CLA. |
loosebazooka
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the contents of stdout and stderr when creating junit test results.
I'm not sure if there is a formal definition of junit, so I followed https://github.com/testmoapp/junitxml and it seems to work in CircleCI.
(I couldn't see a pull request template, I'll be happy to add anything necessary)