Make webapp2_extras/appengine/auth/models.User.validate_token return …

[karlwmacmillan]

…UserToken or None.

Make the implementation of webapp2_extras/appengine/auth/models.User.validate_token match
the documentation and return the UserToken instead of Bool. Also correct the unit tests.

This fixes issue #102.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[codecov-io]

Current coverage is 95.80%

Merging #109 into master will not affect coverage as of 442b167

@@            master   #109   diff @@
=====================================
  Files           23     23       
  Stmts         1884   1884       
  Branches       286    286       
  Methods          0      0       
=====================================
  Hit           1805   1805       
  Partial         58     58       
  Missed          21     21       

Review entire Coverage Diff as of 442b167

Powered by Codecov. Updated on successful CI builds.

[theacodes]

assertNotNone?

[karlwmacmillan]

Fixed.

[theacodes]

Have you pushed? I'm not seeing your updates.

[karlwmacmillan]

Sorry - I screwed up amending the commit. Should be there now.

[theacodes]

I'm seeing some of the assertNone but not the assertIsNotNones.

[karlwmacmillan]

On Apr 11, 2016, at 2:59 PM, Jon Wayne Parrott notifications@github.com wrote:

In tests/extras_appengine_auth_models_test.py #109 (comment):

@@ -141,14 +141,14 @@ def test_user_token(self):
auth_id = 'foo'

     token = m.create_auth_token(auth_id)

•    self.assertTrue(m.validate_auth_token(auth_id, token))
  

•    self.assertTrue(m.validate_auth_token(auth_id, token) != None)
  

  I'm seeing some of the assertNone but not the assertIsNotNones.

Yeah - well, that’s because I didn’t change them :/ And it’s assertIsNone.

Here’s hoping that everything is right this time and I can stop embarrassing myself with this trivial change :)

[karlwmacmillan]

I signed it!

[googlebot]

CLAs look good, thanks!

[theacodes]

Thanks, @karlwmacmillan!