Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Support serviceAccount field for AppEngine flex #949

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Support serviceAccount field for AppEngine flex #949

merged 1 commit into from
Sep 2, 2022

Conversation

modular-magician
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#11813

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

appengine: Added field `serviceAccount` to `app_engine_flexible_app_version`

Derived from GoogleCloudPlatform/magic-modules#6391

@modular-magician @melinath
Support serviceAccount field for AppEngine flex (#6391)
2f79086 
* Support serviceAccount field for AppEngine flex

* Add service account example

* Update account_id

* Use vars instead of test env vars

* Move account id to right tf example

* Update mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add logs writer and network user role

* Update mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add objectViewer role

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner September 2, 2022 18:45
@modular-magician modular-magician requested review from iyabchen and removed request for a team September 2, 2022 18:45
@modular-magician modular-magician merged commit 9368c08 into GoogleCloudPlatform:main Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iyabchen iyabchen Awaiting requested review from iyabchen iyabchen is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support non default service accounts for AppEngine Flex
1 participant
@modular-magician