network.tf file to create networking resources for Splunk export #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarsan
requested changes
Apr 28, 2021
I was so in the mode of running |
rarsan
reviewed
Apr 29, 2021
rarsan
requested changes
Apr 29, 2021
There was a problem hiding this comment.
Looks good. Mind adding changes in the README? Particularly new user-facing variables.
Sorry forgot to mention that last time.
Also there's a simple variables placeholder file variables.yaml that needs to be updated with these new vars. It's made available for end-users to seed a new user-specific terraform.tfvars as described in README setup section.
rarsan
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform fmtto clean up files